[MySQL] Fix minor issue in execute statement packet #739
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…th(): Encode a 1 for iteration-count instead of 0
|
Thanks! |
|
Thank you :) cheers! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The MySQL protocol specifies that the
iteration-countfield should always be set to 1, but MySQL itself ignores the field entirely. Vitess is more strict and will reject execute packets withiteration-countset to anything other than 1.It sounds like they may change to mimic actual MySQL behavior, but I figured you would like to also have the protocol correction on your end, even if it is borderline pedantic :)